lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Jul 2018 02:16:55 +0000 From: Anson Huang <anson.huang@....com> To: "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, Fabio Estevam <fabio.estevam@....com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "mark.rutland@....com" <mark.rutland@....com> CC: dl-linux-imx <linux-imx@....com>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH V2] ARM: dts: make pfuze switch always-on for imx platforms Hi, Shawn Although the commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") is reverted to avoid the boot failure on some i.MX platforms, but adding the "regulator-always-on" property for those pfuze's critical switches are the right way and making sense, no matter how the pfuze regulator's switch ON/OFF function will be implemented, below patches should can be applied anyway? ARM: dts: imx6sll-evk: make pfuze100 sw4 always on ARM: dts: make pfuze switch always-on for imx platforms ARM: dts: imx6sl-evk: keep sw4 always on Let me know your thoughts, thanks! Anson Huang Best Regards! > -----Original Message----- > From: Anson Huang > Sent: Wednesday, June 27, 2018 9:31 AM > To: shawnguo@...nel.org; s.hauer@...gutronix.de; kernel@...gutronix.de; > Fabio Estevam <fabio.estevam@....com>; robh+dt@...nel.org; > mark.rutland@....com > Cc: dl-linux-imx <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org; > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org > Subject: [PATCH V2] ARM: dts: make pfuze switch always-on for imx platforms > > commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") > will cause those unreferenced switches being turned off if > "regulator-always-on" is NOT present, as pfuze switches are normally used by > critical modules which must be always ON or shared by many peripherals which > do NOT implement power domain control, so just make sure all switches > always ON to avoid any system issue caused by unexpectedly turning off > switches. > > Fixes: 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for switch") > Signed-off-by: Anson Huang <Anson.Huang@....com> > Reviewed-by: Fabio Estevam <fabio.estevam@....com> > --- > changes since V1: > improve the way of referencing commit, and add fix tag. > arch/arm/boot/dts/imx6q-display5.dtsi | 1 + > arch/arm/boot/dts/imx6q-mccmon6.dts | 1 + > arch/arm/boot/dts/imx6q-novena.dts | 1 + > arch/arm/boot/dts/imx6q-pistachio.dts | 1 + > arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 1 + > arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 1 + > arch/arm/boot/dts/imx6sx-sdb-reva.dts | 1 + > 7 files changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6q-display5.dtsi > b/arch/arm/boot/dts/imx6q-display5.dtsi > index 85232c7..33d266f 100644 > --- a/arch/arm/boot/dts/imx6q-display5.dtsi > +++ b/arch/arm/boot/dts/imx6q-display5.dtsi > @@ -326,6 +326,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > diff --git a/arch/arm/boot/dts/imx6q-mccmon6.dts > b/arch/arm/boot/dts/imx6q-mccmon6.dts > index b7e9f38..e6429c5 100644 > --- a/arch/arm/boot/dts/imx6q-mccmon6.dts > +++ b/arch/arm/boot/dts/imx6q-mccmon6.dts > @@ -166,6 +166,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > diff --git a/arch/arm/boot/dts/imx6q-novena.dts > b/arch/arm/boot/dts/imx6q-novena.dts > index fcd824d..0b3c651 100644 > --- a/arch/arm/boot/dts/imx6q-novena.dts > +++ b/arch/arm/boot/dts/imx6q-novena.dts > @@ -341,6 +341,7 @@ > reg_sw4: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > reg_swbst: swbst { > diff --git a/arch/arm/boot/dts/imx6q-pistachio.dts > b/arch/arm/boot/dts/imx6q-pistachio.dts > index a31e83c..6ea09f9 100644 > --- a/arch/arm/boot/dts/imx6q-pistachio.dts > +++ b/arch/arm/boot/dts/imx6q-pistachio.dts > @@ -253,6 +253,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > diff --git a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > index a1a6fb5..281cae5 100644 > --- a/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-gw54xx.dtsi > @@ -268,6 +268,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > index 15744ad..6e46a19 100644 > --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi > @@ -341,6 +341,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > diff --git a/arch/arm/boot/dts/imx6sx-sdb-reva.dts > b/arch/arm/boot/dts/imx6sx-sdb-reva.dts > index e3533e7..9cc6ff2 100644 > --- a/arch/arm/boot/dts/imx6sx-sdb-reva.dts > +++ b/arch/arm/boot/dts/imx6sx-sdb-reva.dts > @@ -63,6 +63,7 @@ > sw4_reg: sw4 { > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <3300000>; > + regulator-always-on; > }; > > swbst_reg: swbst { > -- > 2.7.4
Powered by blists - more mailing lists