linux-kernel - Re: [PATCH v5 1/2] media: imx274: use regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201807140225.cKmtgIPL%fengguang.wu@intel.com>
Date:   Sat, 14 Jul 2018 02:46:22 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Luca Ceresoli <luca@...aceresoli.net>
Cc:     kbuild-all@...org, linux-media@...r.kernel.org,
        Luca Ceresoli <luca@...aceresoli.net>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Leon Luo <leonl@...pardimaging.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] media: imx274: use regmap_bulk_write to write
 multybyte registers

Hi Luca,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20180713]
[cannot apply to v4.18-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luca-Ceresoli/media-imx274-cleanups-improvements-and-SELECTION-API-support/20180706-032128
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-sb0-07140141 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/media/i2c/imx274.c: In function 'imx274_write_mbreg':
>> drivers/media/i2c/imx274.c:714:4: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' [-Wformat=]
       __func__, addr, val, nbytes);
       ^
   drivers/media/i2c/imx274.c:716:3: warning: format '%ld' expects argument of type 'long int', but argument 7 has type 'size_t' [-Wformat=]
      dev_dbg(&priv->client->dev,
      ^

vim +714 drivers/media/i2c/imx274.c

   692	
   693	/**
   694	 * Write a multibyte register.
   695	 *
   696	 * Uses a bulk write where possible.
   697	 *
   698	 * @priv: Pointer to device structure
   699	 * @addr: Address of the LSB register.  Other registers must be
   700	 *        consecutive, least-to-most significant.
   701	 * @val: Value to be written to the register (cpu endianness)
   702	 * @nbytes: Number of bits to write (range: [1..3])
   703	 */
   704	static int imx274_write_mbreg(struct stimx274 *priv, u16 addr, u32 val,
   705				      size_t nbytes)
   706	{
   707		__le32 val_le = cpu_to_le32(val);
   708		int err;
   709	
   710		err = regmap_bulk_write(priv->regmap, addr, &val_le, nbytes);
   711		if (err)
   712			dev_err(&priv->client->dev,
   713				"%s : i2c bulk write failed, %x = %x (%ld bytes)\n",
 > 714				__func__, addr, val, nbytes);
   715		else
   716			dev_dbg(&priv->client->dev,
   717				"%s : addr 0x%x, val=0x%x (%ld bytes)\n",
   718				__func__, addr, val, nbytes);
   719		return err;
   720	}
   721	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30625 bytes)