linux-kernel - Re: [PATCH net-next v2 5/7] net: mvneta: Allocate page for the descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180713.182311.1329076241299839709.davem@davemloft.net>
Date:   Fri, 13 Jul 2018 18:23:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gregory.clement@...tlin.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, linux-arm-kernel@...ts.infradead.org,
        jason@...edaemon.net, andrew@...n.ch,
        sebastian.hesselbarth@...il.com, yelena@...vell.com,
        nadavh@...vell.com, mw@...ihalf.com, dima@...vell.com,
        antoine.tenart@...tlin.com, miquel.raynal@...tlin.com,
        maxime.chevallier@...tlin.com
Subject: Re: [PATCH net-next v2 5/7] net: mvneta: Allocate page for the
 descriptor

From: Gregory CLEMENT <gregory.clement@...tlin.com>
Date: Fri, 13 Jul 2018 18:18:39 +0200

> -static int mvneta_rx_refill(struct mvneta_port *pp,
> -			    struct mvneta_rx_desc *rx_desc,
> -			    struct mvneta_rx_queue *rxq)
> -
> +/* Allocate page per descriptor */
> +static inline int mvneta_rx_refill(struct mvneta_port *pp,
> +				   struct mvneta_rx_desc *rx_desc,

Please do not use inline functions in foo.c files, let the compiler
decide.

Thank you.