linux-kernel - Re: [PATCH 14/18] staging: gasket: fix class create bug handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE_wzQ9aCarAOmBECwmfUjZjWBXzOHiE3OahG0WvZXeLoJvjVw@mail.gmail.com>
Date:   Sat, 14 Jul 2018 11:16:03 +0300
From:   Dmitry Torokhov <dtor@...omium.org>
To:     toddpoynor@...il.com
Cc:     rspringer@...gle.com, jnjoseph@...gle.com, benchan@...omium.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        frankhu@...omium.org, Simon Que <sque@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        devel@...verdev.osuosl.org, lkml <linux-kernel@...r.kernel.org>,
        toddpoynor@...gle.com
Subject: Re: [PATCH 14/18] staging: gasket: fix class create bug handling

On Sat, Jul 14, 2018 at 8:59 AM Todd Poynor <toddpoynor@...il.com> wrote:
>
> From: Todd Poynor <toddpoynor@...gle.com>
>
> class_create() never returns NULL, and this driver should never return
> PTR_ERR(NULL) anyway.
>
> Reported-by: Dmitry Torokhov <dtor@...omium.org>
> Signed-off-by: Zhongze Hu <frankhu@...omium.org>
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>

Reviewed-by: Dmitry Torokhov <dtor@...omium.org>

> ---
>  drivers/staging/gasket/gasket_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index f7d8f66e8746..0ef37667e0f1 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -341,7 +341,7 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
>         internal->class =
>                 class_create(driver_desc->module, driver_desc->name);
>
> -       if (IS_ERR_OR_NULL(internal->class)) {
> +       if (IS_ERR(internal->class)) {
>                 gasket_nodev_error("Cannot register %s class [ret=%ld]",
>                                    driver_desc->name, PTR_ERR(internal->class));
>                 ret = PTR_ERR(internal->class);
> --
> 2.18.0.203.gfac676dfb9-goog
>