[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180714085109.mbhk6aybpjsbuq6l@penguin>
Date: Sat, 14 Jul 2018 08:51:09 +0000
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Marcus Folkesson <marcus.folkesson@...il.com>
Cc: Alexey Khoroshilov <khoroshilov@...ras.ru>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
ldv-project@...uxtesting.org
Subject: Re: [PATCH] Input: pxrc - fix leak of usb_device
On Sat, Jul 14, 2018 at 10:09:20AM +0200, Marcus Folkesson wrote:
> Hi Alexey,
>
> Good catch!
>
> On Fri, Jul 13, 2018 at 11:07:57PM +0300, Alexey Khoroshilov wrote:
> > pxrc_probe() calls usb_get_dev(), but there is no usb_put_dev()
> > anywhere in the driver.
> >
> > The patch adds one to error handling code and to pxrc_disconnect().
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
>
> Reviewed-by: Marcus Folkesson <marcus.folkesson@...il.com>
Hmm, the biggest question however if we need to "take" the device, as I
do not think interface can outlive the device, and whether we actually
need to store it in pxrc, as we only need it during set up, as far as I
can see.
Thanks.
--
Dmitry
Powered by blists - more mailing lists