linux-kernel - Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pnzpvdtd.fsf@xmission.com>
Date:   Sat, 14 Jul 2018 14:04:46 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Kees Cook <keescook@...omium.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Adrian Reber <adrian@...as.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Pavel Emelyanov <xemul@...tuozzo.com>,
        Andrei Vagin <avagin@...tuozzo.com>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Linux Containers <containers@...ts.linux-foundation.org>,
        Josh Triplett <josh@...htriplett.org>
Subject: Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

Kees Cook <keescook@...omium.org> writes:

> On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton
> <akpm@...ux-foundation.org> wrote:
>> On Thu, 12 Jul 2018 11:33:33 -0500 ebiederm@...ssion.com (Eric W. Biederman) wrote:
>>> What is the value of disabling this functionality ever?
>>>
>>> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE
>>> entirely?
>>
>> For the vast number of Linux machines which aren't servers?  Check out
>> some defconfigs - only one of arm's 119 defconfigs selects it.
>
> Right, and I would bet the minification folks would like to keep it
> out of their builds too. I think we should keep the config.

I take it then you are volunteering to test with and without the config
option?

Even if the config option is kept I intend to rip it out every time I
wind up touching code with it in.  Config options have a real cost in
testing and development.

For a config option that no one has come forward with an actual real
world use case for disabling, that cost seems much too high.

Eric