linux-kernel - Re: [PATCH] vme: ca91cx42: remove redundant variable i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180714212236.buwuefu2j7a7fqfl@hades.welchs.me.uk>
Date:   Sat, 14 Jul 2018 22:22:37 +0100
From:   Martyn Welch <martyn@...chs.me.uk>
To:     Colin King <colin.king@...onical.com>
Cc:     Manohar Vanga <manohar.vanga@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vme: ca91cx42: remove redundant variable i

On Sat, Jul 14, 2018 at 05:33:32PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable i is being assigned but is never used hence it is redundant
> and can be removed.
> 
> Cleans up clang warning:
> warning: variable 'i' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Martyn Welch <martyn@...chs.me.uk>

> ---
>  drivers/vme/bridges/vme_ca91cx42.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx42.c
> index 5dd284008630..53bdc256805f 100644
> --- a/drivers/vme/bridges/vme_ca91cx42.c
> +++ b/drivers/vme/bridges/vme_ca91cx42.c
> @@ -970,7 +970,6 @@ static unsigned int ca91cx42_master_rmw(struct vme_master_resource *image,
>  {
>  	u32 result;
>  	uintptr_t pci_addr;
> -	int i;
>  	struct ca91cx42_driver *bridge;
>  	struct device *dev;
>  
> @@ -978,7 +977,6 @@ static unsigned int ca91cx42_master_rmw(struct vme_master_resource *image,
>  	dev = image->parent->parent;
>  
>  	/* Find the PCI address that maps to the desired VME address */
> -	i = image->number;
>  
>  	/* Locking as we can only do one of these at a time */
>  	mutex_lock(&bridge->vme_rmw);
> -- 
> 2.17.1
>