linux-kernel - Re: [f2fs-dev] [PATCH] fs: f2fs: Insert a space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20180715025021.GE11571@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Sun, 15 Jul 2018 11:50:21 +0900
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     youngjun yoo <youngjun.willow@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] fs: f2fs: Insert a space

Hi Youngjun,

Look like you sent several patches to fix checkpatch error.
Could you please write single patch saying "f2fs: clean up coding style", which
contains all the changes that you want to fix?

Thanks,

On 07/14, youngjun yoo wrote:
> clean up checkpatch error:
> ERROR:
> space required before the open parenthesis (
> space required around that :
> Signed-off-by: willow72 <youngjun.willow@...il.com>
> ---
>  fs/f2fs/node.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 51388cf..14ed45c 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -1225,7 +1225,7 @@ static struct page *__get_node_page(struct f2fs_sb_info *sbi, pgoff_t nid,
>  		goto out_err;
>  	}
>  page_hit:
> -	if(unlikely(nid != nid_of_node(page))) {
> +	if (unlikely (nid != nid_of_node (page))) {
>  		f2fs_msg(sbi->sb, KERN_WARNING, "inconsistent node block, "
>  			"nid:%lu, node_footer[nid:%u,ino:%u,ofs:%u,cpver:%llu,blkaddr:%u]",
>  			nid, nid_of_node(page), ino_of_node(page),
> @@ -1589,7 +1589,7 @@ int f2fs_fsync_node_pages(struct f2fs_sb_info *sbi, struct inode *inode,
>  out:
>  	if (last_idx != ULONG_MAX)
>  		f2fs_submit_merged_write_cond(sbi, NULL, ino, last_idx, NODE);
> -	return ret ? -EIO: 0;
> +	return ret ? -EIO : 0;
>  }
>  
>  int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
> -- 
> 2.7.4
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel