linux-kernel - Re: [PATCH net,v2] tcp: Fix broken repair socket window probe patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.140846.1194638558934032830.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 14:08:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sbaranoff@...il.com
Cc:     avagin@...tuozzo.com, xemul@...tuozzo.com, edumazet@...gle.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net,v2] tcp: Fix broken repair socket window probe patch

From: Stefan Baranoff <sbaranoff@...il.com>
Date: Sun, 15 Jul 2018 11:36:37 -0400

> Correct previous bad attempt at allowing sockets to come out of TCP
> repair without sending window probes. To avoid changing size of
> the repair variable in struct tcp_sock, this lets the decision for
> sending probes or not to be made when coming out of repair by
> introducing two ways to turn it off.
> 
> v2:
> * Remove erroneous comment; defines now make behavior clear
> 
> Fixes: 70b7ff130224 ("tcp: allow user to create repair socket without window probes")
> Signed-off-by: Stefan Baranoff <sbaranoff@...il.com>

Applied and queued up for -stable.