[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180716214354.GA10734@amd>
Date: Mon, 16 Jul 2018 23:43:54 +0200
From: Pavel Machek <pavel@....cz>
To: David Lechner <david@...hnology.com>
Cc: Baolin Wang <baolin.wang@...aro.org>, jacek.anaszewski@...il.com,
bjorn.andersson@...aro.org, broonie@...nel.org,
linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/2] leds: core: Introduce generic pattern interface
On Mon 2018-07-16 11:51:01, David Lechner wrote:
> On 07/16/2018 06:10 AM, Baolin Wang wrote:
> >From: Bjorn Andersson <bjorn.andersson@...aro.org>
> >
> >Some LED controllers have support for autonomously controlling
> >brightness over time, according to some preprogrammed pattern or
> >function.
> >
> >This adds a new optional operator that LED class drivers can implement
> >if they support such functionality as well as a new device attribute to
> >configure the pattern for a given LED.
> >
>
> Hmm... I was hoping that this would be a generic pattern trigger that
> could be used by any LED (e.g. gpio LEDs), not just LEDs with hardware
> support. I guess I cannot really test this after all.
>
> I think it looks good for your use case though.
Generic trigger doing patterns on any hardware would be welcome, too.
I even have a copy of code somewhere, if you want to dust it off,
clean up and merge...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists