linux-kernel - Re: [PATCH 2/8] efi/x86: Use non-blocking SetVariable() for efi_delete_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180716010219.GA13742@gmail.com>
Date:   Mon, 16 Jul 2018 03:02:19 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@...el.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8] efi/x86: Use non-blocking SetVariable() for
 efi_delete_dummy_variable()


* Prakhya, Sai Praneeth <sai.praneeth.prakhya@...el.com> wrote:

> > > diff --git a/arch/x86/platform/efi/quirks.c
> > > b/arch/x86/platform/efi/quirks.c index 36c1f8b9f7e0..6af39dc40325
> > > 100644
> > > --- a/arch/x86/platform/efi/quirks.c
> > > +++ b/arch/x86/platform/efi/quirks.c
> > > @@ -105,12 +105,11 @@ early_param("efi_no_storage_paranoia",
> > > setup_storage_paranoia);  */  void efi_delete_dummy_variable(void)  {
> > > -	efi.set_variable((efi_char16_t *)efi_dummy_name,
> > > -			 &EFI_DUMMY_GUID,
> > > -			 EFI_VARIABLE_NON_VOLATILE |
> > > -			 EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > > -			 EFI_VARIABLE_RUNTIME_ACCESS,
> > > -			 0, NULL);
> > > +	efi.set_variable_nonblocking((efi_char16_t *)efi_dummy_name,
> > > +				     &EFI_DUMMY_GUID,
> > > +				     EFI_VARIABLE_NON_VOLATILE |
> > > +				     EFI_VARIABLE_BOOTSERVICE_ACCESS |
> > > +				     EFI_VARIABLE_RUNTIME_ACCESS, 0, NULL);
> > >  }
> > 
> > Just wondering, what is the full stack trace of the splat? It sounds a bit surprising
> > to me that such type of EFI code is used from the idle thread.
> 
> Sorry! for the confusing commit message. Kernel warns about scheduling from idle 
> thread only when "efi_rts_wq" is used to invoke efi_runtime_services(). So, 
> presently, this doesn't happen on mainline kernel. Support for "efi_rts_wq" is 
> added by commit 3eb420e70d87 (efi: Use a work queue to invoke EFI Runtime 
> Services).

Ok, that makes a lot more sense!

Thanks,

	Ingo