linux-kernel - Re: [PATCH 14/18] kdb_support: change strncpy+truncation to strlcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180716082339.tcczk5tdnruhr47x@holly.lan>
Date:   Mon, 16 Jul 2018 09:23:39 +0100
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Dominique Martinet <asmadeus@...ewreck.org>
Cc:     David Laight <David.Laight@...LAB.COM>,
        Jason Wessel <jason.wessel@...driver.com>,
        Arnd Bergmann <arnd@...db.de>,
        kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/18] kdb_support: change strncpy+truncation to strlcpy

On Fri, Jul 13, 2018 at 05:18:51PM +0200, Dominique Martinet wrote:
> Daniel Thompson wrote on Fri, Jul 13, 2018:
> > On Fri, Jul 13, 2018 at 03:25:58AM +0200, Dominique Martinet wrote:
> > > Generated by scripts/coccinelle/misc/strncpy_truncation.cocci
> > > 
> > > Signed-off-by: Dominique Martinet <asmadeus@...ewreck.org>
> > 
> > It would have been good for you to mention in the changelog how
> > you reviewed your change to verify that the extra zero padding
> > from strncpy() isn't required.
> 
> I'm sorry, I went a bit too fast with the send-email button on this
> path series; I agree it is lacking.
> 
> > However... I have taken a look and can't see any problem so:
> > 
> > Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
> 
> Thank you for the review, I will update the commit message with more
> details and change strlcpy to strscpy in a v2

You can keep the reviewed by after the change to strscpy().