lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180716084205.GC8260@kroah.com>
Date:   Mon, 16 Jul 2018 10:42:05 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        kstewart@...uxfoundation.org, pombredanne@...b.com,
        tglx@...utronix.de
Subject: Re: [PATCH 02/10] staging:rtl8192u: remove typedef of struct
 TS_COMMON_INFO - Style

On Fri, Jul 13, 2018 at 09:12:39PM +0100, John Whitmore wrote:
> To clear a checkpatch issue removed the typedef of the structure
> TS_COMMON_INFO.
> 
> This change removes the previous declaration, which defined two types, both
> TS_COMMON_INFO and a pointer type PTS_COMMON_INFO:
> 
> typedef struct _TS_COMMON_INFO {
> 	...
> } TS_COMMON_INFO, *PTS_COMMON_INFO;
> 

Same here, this should be "struct ts_common_info", not TS_COMMON_INFO.

Can you fix both of these issues up and resend the series?

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ