linux-kernel - [tip:x86/hyperv] x86/hyper-v: Check cpumask_to_vpset() return value in hyperv_flush_tlb_others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-0f0caa52cd4a48a44f6cdc77bf83272bbb450727@git.kernel.org>
Date:   Mon, 16 Jul 2018 02:24:56 -0700
From:   tip-bot for Vitaly Kuznetsov <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
        kys@...rosoft.com, sthemmin@...rosoft.com,
        Michael.H.Kelley@...rosoft.com, mingo@...nel.org,
        haiyangz@...rosoft.com, vkuznets@...hat.com, mikelley@...rosoft.com
Subject: [tip:x86/hyperv] x86/hyper-v: Check cpumask_to_vpset() return value
 in hyperv_flush_tlb_others_ex()

Commit-ID:  0f0caa52cd4a48a44f6cdc77bf83272bbb450727
Gitweb:     https://git.kernel.org/tip/0f0caa52cd4a48a44f6cdc77bf83272bbb450727
Author:     Vitaly Kuznetsov <vkuznets@...hat.com>
AuthorDate: Mon, 9 Jul 2018 19:40:11 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 16 Jul 2018 11:19:48 +0200

x86/hyper-v: Check cpumask_to_vpset() return value in hyperv_flush_tlb_others_ex()

Commit 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI
enlightenment") made cpumask_to_vpset() return '-1' when there is a CPU
with unknown VP index in the supplied set. This needs to be checked before
we pass 'nr_bank' to hypercall.

Fixes: 1268ed0c474a ("x86/hyper-v: Fix the circular dependency in IPI enlightenment")
Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
Cc: "K. Y. Srinivasan" <kys@...rosoft.com>
Cc: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Stephen Hemminger <sthemmin@...rosoft.com>
Cc: "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com>
Cc: devel@...uxdriverproject.org
Cc: "H. Peter Anvin" <hpa@...or.com>
Link: https://lkml.kernel.org/r/20180709174012.17429-2-vkuznets@redhat.com

---
 arch/x86/hyperv/mmu.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c
index 0d90e515ec98..453d2355cd61 100644
--- a/arch/x86/hyperv/mmu.c
+++ b/arch/x86/hyperv/mmu.c
@@ -186,6 +186,8 @@ static u64 hyperv_flush_tlb_others_ex(const struct cpumask *cpus,

 	flush->hv_vp_set.format = HV_GENERIC_SET_SPARSE_4K;
 	nr_bank = cpumask_to_vpset(&(flush->hv_vp_set), cpus);
+	if (nr_bank < 0)
+		return U64_MAX;

 	/*
 	 * We can flush not more than max_gvas with one hypercall. Flush the