linux-kernel - Re: [PATCH] base: core: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2043787.xsU0OtZjGC@aspire.rjw.lan>
Date:   Mon, 16 Jul 2018 11:45:11 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Benjamin Gaignard <benjamin.gaignard@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Mark Brown <broonie@...nel.org>,
        pascal paillet <p.paillet@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Benjamin Gaignard <benjamin.gaignard@...com>
Subject: Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

On Thursday, July 12, 2018 11:18:26 AM CEST Benjamin Gaignard wrote:
> 2018-07-12 10:55 GMT+02:00 Greg KH <gregkh@...uxfoundation.org>:
> > On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote:
> >> In some cases the link between between customer and supplier
> >> already exist. Do not warn about already existing dependencies
> >> because device_link_add() take care of this case.
> >
> > Why would a link already exist that is asked to be created again?  What
> > code path causes this?
> 
> It could happen that the link exist because a device use it parent as supplier.
> That case has been describe by Marek in this thread (I forgot to add
> it in the commit message, sorry):
> https://lkml.org/lkml/2018/7/9/356

So please add this information to the patch changelog and resend.

Thanks,
Rafael