linux-kernel - Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Jul 2018 12:02:30 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     RAGHU Halharvi <raghuhack78@...il.com>
Cc:     devel@...verdev.osuosl.org, driverdev-devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, wsa@...-dreams.de
Subject: Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning

On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> 	message"
> 
> Signed-off-by: RAGHU Halharvi <raghuhack78@...il.com>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
>  	card = sdio_get_drvdata(func);
>  
>  	pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> -	if (!pp) {
> -		netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> +	if (!pp)
>  		return -ENOMEM;
> -	}

This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.

thanks,

greg k-h