linux-kernel - Re: staging:rtl8192u: [0/10] Coding style changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180716113457.GB22731@xux707-tw>
Date:   Mon, 16 Jul 2018 12:34:58 +0100
From:   John Whitmore <arigead@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        tglx@...utronix.de, kstewart@...uxfoundation.org,
        pombredanne@...b.com
Subject: Re: staging:rtl8192u: [0/10] Coding style changes.

On Mon, Jul 16, 2018 at 10:40:20AM +0200, Greg KH wrote:
> On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote:
> > All coding style changes, but the second [2/10] is a bit more hairy then
> > most. The original code combined two typedef declarations into one with both
> > the structure and a pointer to the structure defined. I've totally removed the
> > pointer to the structure type since it uses Hungarian notation, which the
> > coding standard isn't keen on.
> > 
> > As a result of this there are changes in code from the type:
> > PStructType  *ppname;
> > to:
> > struct StructType **ppname;
> > 
> > To keep the diff simple I've kept the current nameing of "ppname", which again
> > is Hungarian notation. I'll leave that for a future patch.
> 
> Nit, your subject should look like:
> 
> Subject: [PATCH 00/10] staging:rtl8192u: Coding style changes.
> 
> What are you using to generate this email?  git format-patch
> --cover-letter should generate it with a correct subject line prefix,
> right?
> 

Oops! I was using "git send-email --compose" didn't realise that option was
included in format-patch. I'll use that format-patch option in future.

John