linux-kernel - Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7hbmb7mh68.fsf@baylibre.com>
Date:   Mon, 16 Jul 2018 08:41:35 -0500
From:   Kevin Hilman <khilman@...libre.com>
To:     Jian Hu <jian.hu@...ogic.com>
Cc:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        <jbrunet@...libre.com>, Neil Armstrong <narmstrong@...libre.com>,
        <qianggui.song@...ogic.com>, <sboyd@...nel.org>,
        <mturquette@...libre.com>, <yixun.lan@...ogic.com>,
        <linux-kernel@...r.kernel.org>, <bo.yang@...ogic.com>,
        <qiufang.dai@...ogic.com>, <linux-arm-kernel@...ts.infradead.org>,
        <carlo@...one.org>, <linux-amlogic@...ts.infradead.org>,
        <sunny.luo@...ogic.com>, <linux-clk@...r.kernel.org>,
        <xingyu.chen@...ogic.com>
Subject: Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

Jian Hu <jian.hu@...ogic.com> writes:

> On 2018/7/10 5:53, Martin Blumenstingl wrote:
>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu <jian.hu@...ogic.com> wrote:

[...]

>>> +static const struct of_device_id clkc_match_table[] = {
>>> +       { .compatible = "amlogic,g12a-clkc" },
>> I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG
>> and GXBB/GXL/GXM omit the "meson-" prefix, but I am not sure if that's
>> correct - I'll CC Rob Herring on the dt-bindings patch)
>>
> For clock drivers,they omit the "meson-" prefix, But for common
> amlogic drivers use "amlogic.meson-<chip>-<ip>".
> So which type should we choose? .compatible = "amlogic,g12a-clkc or
>
> .compatible = "amlogic,meson-g12a-clkc

Please follow the existing pattern for clock drivers, omitting the
"meson-" prefix.

Kevin