linux-kernel - Re: [PATCH v6 4/4] PCI: Introduce the disable_acs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a195c47-0a3d-e2f0-588b-214f6720528a@deltatee.com>
Date:   Mon, 16 Jul 2018 11:17:07 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-doc@...r.kernel.org, Stephen Bates <sbates@...thlin.com>,
        Christoph Hellwig <hch@....de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Christian König <christian.koenig@....com>,
        Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH v6 4/4] PCI: Introduce the disable_acs_redir parameter



On 16/07/18 11:15 AM, Alex Williamson wrote:
>> +	pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS);
>> +	if (!pos) {
>> +		pci_warn(dev, "cannot disable ACS redirect for this hardware as it does not have ACS capabilities\n");
>> +		return;
>> +	}
>> +
>> +	if (!pci_dev_specific_disable_acs_redir(dev))
>> +		return;
> 
> Shouldn't this come before the above ACS capability test?  The PCH
> quirk without a disable_acs_redir callback will fall out with the
> pci_warn() above either way, but this ordering precludes that a quirk
> could be written for that device since it doesn't have an ACS
> capability.  Otherwise the series looks ok to me.  Thanks,

Yup, nice catch. I'll respin a v7 shortly.

Thanks,

Logan