lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAO3upobJBYVz7Gh+Ghckh8mYbx9UpAG7xmCC2qcjsRb7em3eaA@mail.gmail.com>
Date:   Tue, 17 Jul 2018 12:52:28 -0700
From:   Todd Poynor <toddpoynor@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, Zhongze Hu <frankhu@...omium.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Simon Que <sque@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Todd Poynor <toddpoynor@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return
 when condition hit

On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote:
>> From: Todd Poynor <toddpoynor@...gle.com>
>>
>> Return right away instead of break out of while and then return.
>>
>
> You could remove the (retries == max_retries) condition since that's
> always true now and pull that code in one tab.  You could do it in one
> patch because they're closely related so it's One Thing [tm].

Ah yes, also removed the impossible-to-reach "return 0" at the end,
thanks -- Todd

>
> regads,
> dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ