linux-kernel - RE: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN1PR02MB3758432C38CC9580BC96182DB85C0@SN1PR02MB3758.namprd02.prod.outlook.com>
Date:   Tue, 17 Jul 2018 20:01:40 +0000
From:   Jolly Shah <JOLLYS@...inx.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "hkallweit1@...il.com" <hkallweit1@...il.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "matt@...eblueprint.co.uk" <matt@...eblueprint.co.uk>,
        Michal Simek <michals@...inx.com>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "sboyd@...eaurora.org" <sboyd@...eaurora.org>,
        "sudeep.holla@....com" <sudeep.holla@....com>
CC:     Rajan Vaja <RAJANV@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API

Hi Stephen,

Thanks for the review,

> -----Original Message-----
> From: Stephen Boyd [mailto:sboyd@...nel.org]
> Sent: Sunday, July 08, 2018 10:29 PM
> To: Jolly Shah <JOLLYS@...inx.com>; ard.biesheuvel@...aro.org;
> dmitry.torokhov@...il.com; gregkh@...uxfoundation.org;
> hkallweit1@...il.com; keescook@...omium.org; linux-clk@...r.kernel.org;
> mark.rutland@....com; matt@...eblueprint.co.uk; Michal Simek
> <michals@...inx.com>; mingo@...nel.org; mturquette@...libre.com;
> robh+dt@...nel.org; sboyd@...eaurora.org; sudeep.holla@....com
> Cc: Rajan Vaja <RAJANV@...inx.com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; devicetree@...r.kernel.org; Jolly Shah
> <JOLLYS@...inx.com>
> Subject: Re: [PATCH v9 07/10] firmware: xilinx: Add debugfs for IOCTL API
> 
> Quoting Jolly Shah (2018-06-20 10:40:32)
> > From: Rajan Vaja <rajanv@...inx.com>
> >
> > Add debugfs file to set/get IOCTL using debugfs interface.
> 
> IOCTLs and debugfs aren't the same thing. Why are the two being mixed
> together? Is some sort of userspace ABI being created here to control clks with
> usermode drivers?

This is not standard ioctl. This is type of ZynqMP API just like other APIs. This debugfs is created to debug ZynqMP IOCTL API.

Thanks,
Jolly Shah