linux-kernel - Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180717230839.3fc2264e@bbrezillon>
Date:   Tue, 17 Jul 2018 23:08:39 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Wenyou Yang <wenyou.yang@...rochip.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Richard Weinberger <richard@....at>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Josh Wu <rainyfeeling@...look.com>,
        Romain Izard <romain.izard.pro@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Peter Rosin <peda@...ntia.se>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/3] mtd: atmel nand: fix build warning on 64-bit

On Tue, 17 Jul 2018 23:05:23 +0200
Miquel Raynal <miquel.raynal@...tlin.com> wrote:

> Hi Arnd,
> 
> Arnd Bergmann <arnd@...db.de> wrote on Fri, 13 Jul 2018 12:16:09 +0200:
> 
> > On Fri, Jul 13, 2018 at 11:56 AM, Tudor Ambarus
> > <tudor.ambarus@...rochip.com> wrote:  
> > > Hi, Arnd,
> > >
> > > On 07/09/2018 06:57 PM, Arnd Bergmann wrote:    
> > >> +     nc->ebi_csa_offs = (uintptr_t)match->data;    
> > >
> > > I guess we should declare ebi_csa_offs as size_t, right?    
> > 
> > Yes, that would make sense, though it doesn't change the behavior.
> >   
> 
> Do you plan to send a new version? I don't want to mess with
> improvised casts :)

This fix is already part of my COMPILE_TEST series (v2), and I don't
thing declaring ->ebi_csa_offs as a size_t is useful.