linux-kernel - Re: [PATCH v4 2/2] ARM: dts: am335x: add am335x-sancloud-bbe board support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <5CF84BA0-DF94-4692-A76C-B7A5CE74A226@dominion.thruhere.net>
Date:   Tue, 17 Jul 2018 08:26:21 +0200
From:   Koen Kooi <koen@...inion.thruhere.net>
To:     Tony Lindgren <tony@...mide.com>
Cc:     linux-omap <linux-omap@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Benoît Cousson <bcousson@...libre.com>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] ARM: dts: am335x: add am335x-sancloud-bbe board
 support



> Op 17 jul. 2018, om 08:16 heeft Tony Lindgren <tony@...mide.com> het volgende geschreven:
> 
> Hi Koen,
> 
> Just noticed there should be generic node names here too, see below.
> 
> * Koen Kooi <koen@...inion.thruhere.net> [180713 06:28]:
>> The "Beaglebone Enhanced" by Sancloud is based on the Beaglebone Black,
>> but with the following differences:
>> 
>> * Gigabit capable PHY
>> * Extra USB hub, optional i2c control
>> * lps3331ap barometer connected over i2c
>> * MPU6050 6 axis MEMS accelerometer/gyro connected over i2c
>> * 1GiB DDR3 RAM
>> * RTL8723 Wifi/Bluetooth connected over USB
> 
>> +&i2c0 {
>> +	lps331ap: lps331ap@5C {
>> +		compatible = "st,lps331ap-press";
>> +		st,drdy-int-pin = <1>;
>> +		reg = <0x5C>;
>> +		interrupt-parent = <&gpio1>;
>> +		interrupts = <26 IRQ_TYPE_EDGE_RISING>;
>> +	};
> 
> lps33lap: barometer@5c
> 
>> +	mpu6050: mpu6050@68 {
>> +		compatible = "invensense,mpu6050";
>> +		reg = <0x68>;
>> +		interrupt-parent = <&gpio0>;
>> +		interrupts = <2 IRQ_TYPE_EDGE_RISING>;
>> +		orientation = <0xff 0 0 0 1 0 0 0 0xff>;
>> +	};
> 
> mpu6050: accelerometer@2c
> 
> And so on. Please check the lower case hex numbers too as
> that’s what Linux typically uses.

Thanks for the feedback! Fixed both issues, v5 sent out. 

regards,

Koen

> 
> Thanks,
> 
> Tony