linux-kernel - Re: [PATCH] genirq:Dereference desc after null pointer check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1807170950390.1740@nanos.tec.linutronix.de>
Date:   Tue, 17 Jul 2018 09:51:37 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     RAGHU Halharvi <raghuhack78@...il.com>
cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq:Dereference desc after null pointer check

On Tue, 17 Jul 2018, RAGHU Halharvi wrote:

> * Remove unchecked dereferencing of *desc & assigning it local irq
> 	variable
> * Move the assignement after proper check of *desc for NULL pointer.

Sorry no. The NULL pointer check is pointless because the call sites
already do it before calling that function.

Thanks,

	tglx