linux-kernel - Re: [PATCH 30/32] staging: gasket: gasket_mmap use PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180717104443.rx4viceiphjrmyut@mwanda>
Date:   Tue, 17 Jul 2018 13:44:43 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org, Zhongze Hu <frankhu@...omium.org>,
        linux-kernel@...r.kernel.org, Simon Que <sque@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Todd Poynor <toddpoynor@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>
Subject: Re: [PATCH 30/32] staging: gasket: gasket_mmap use PAGE_MASK

On Mon, Jul 16, 2018 at 07:09:24PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> Instead of math on PAGE_SIZE.
> 

The commit message is sort of distinct from the first line.  The first
line is like a title, not the start of a sentence.  On like marc.info
when you're looking at patches, the Subject and the commit message are
sort of far apart so it looks weird.  It looks weird on my email as
well.

Sorry, we're really hitting you with a bunch of nit-picky stuff.  If you
were a one off contributer I'd just let a lot of this stuff slide but
since you're going to be a maintainer for a while then it's good to
learn all these micro rules at the begining.

regards,
dan carpenter