[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180717124606.GC23935@piout.net>
Date: Tue, 17 Jul 2018 14:46:06 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Wolfram Sang <wsa@...-dreams.de>,
Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
James Hogan <jhogan@...nel.org>,
Paul Burton <paul.burton@...s.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Allan Nielsen <allan.nielsen@...rosemi.com>
Subject: Re: [PATCH 0/5] Add support for MSCC Ocelot i2c
On 17/07/2018 15:21:20+0300, Andy Shevchenko wrote:
> On Tue, 2018-07-17 at 13:48 +0200, Alexandre Belloni wrote:
> > Hi,
> >
> > Because the designware IP was not able to the the SDA hold time, MSCC
> > has
> > its own implementation. Add support for it and then add i2c on ocelot
> > boards.
> >
> > I would expect patches 1 to 3 to go through the i2c tree and 4-5
> > through
> > the mips tree once patch 3 has been reviewed by the DT maintainers.
>
> Without reading datasheet it all feels like a wrong place to put.
>
> But maybe that SoC (SoC family?) has some update to DesignWare IP.
> Btw, what the version of DW IP it's using? 2.00a? More older, more
> recent?
>
COMP_VERSION reads 0x3131302A so it is before DW_IC_SDA_HOLD_MIN_VERS.
>
> > Alexandre Belloni (5):
> > i2c: designware: factorize setting SDA hold time
> > i2c: designware: allow IP specific sda_hold_time
> > i2c: designware: add MSCC Ocelot support
> > mips: dts: mscc: Add i2c on ocelot
> > mips: dts: mscc: enable i2c on ocelot_pcb123
> >
> > .../bindings/i2c/i2c-designware.txt | 5 ++-
> > arch/mips/boot/dts/mscc/ocelot.dtsi | 19 +++++++++++
> > arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 5 +++
> > drivers/i2c/busses/i2c-designware-common.c | 33
> > +++++++++++++++++++
> > drivers/i2c/busses/i2c-designware-core.h | 3 ++
> > drivers/i2c/busses/i2c-designware-master.c | 22 +------------
> > drivers/i2c/busses/i2c-designware-platdrv.c | 20 +++++++++++
> > drivers/i2c/busses/i2c-designware-slave.c | 22 +------------
> > 8 files changed, 86 insertions(+), 43 deletions(-)
> >
>
> --
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Intel Finland Oy
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
Powered by blists - more mailing lists