linux-kernel - Re: [PATCH] Patch enabling Fn function keys for Laptop Asus G730 (keyboard 0x1869)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1807171549510.997@cbobk.fhfr.pm>
Date:   Tue, 17 Jul 2018 15:51:09 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     jan <vereecke.jan@...net.be>
cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        benjamin.tissoires@...hat.com
Subject: Re: [PATCH] Patch enabling Fn function keys for Laptop Asus G730
 (keyboard 0x1869)

On Thu, 5 Jul 2018, jan wrote:

> Thanks for your reply. However, I am confused. Pleas bear with me as this is
> the very first time that I submit a patch and I followed some guidance that I
> found on the internet (obviously not the correct one).
> 
> I suppose I just need to delete the parts of the email where you write "this
> doesn't go in the changelog".

Yeah, please put into the patch changelog only the things that should end 
up in the actual commit log (the thing you see when doing git log / git 
show etc).

> I am not sure what my signoff should contain. Could you point me to a correct
> guide for this ?

Please read

	Documentation/process/submitting-patches.rst

signoffs specifically are discussed in paragraph 11.

Thanks!

-- 
Jiri Kosina
SUSE Labs