linux-kernel - Re: [PATCH] PCI: Unify pci and normal dma direction definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180717140335.GA23500@infradead.org>
Date:   Tue, 17 Jul 2018 07:03:35 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Shunyong Yang <shunyong.yang@...-semitech.com>
Cc:     bhelgaas@...gle.com, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, Joey Zheng <yu.zheng@...-semitech.com>
Subject: Re: [PATCH] PCI: Unify pci and normal dma direction definition

> diff --git a/include/linux/dma-direction.h b/include/linux/dma-direction.h
> index 3649a031893a..9d52716e9218 100644
> --- a/include/linux/dma-direction.h
> +++ b/include/linux/dma-direction.h
> @@ -2,7 +2,7 @@
>  #ifndef _LINUX_DMA_DIRECTION_H
>  #define _LINUX_DMA_DIRECTION_H
>  /*
> - * These definitions mirror those in pci.h, so they can be used
> + * These definitions mirror those in pci-dma-compat.h, so they can be used
>   * interchangeably with their PCI_ counterparts.
>   */

I think we can just drop this comment anymore.

> +#define PCI_DMA_BIDIRECTIONAL	(DMA_BIDIRECTIONAL)
> +#define PCI_DMA_TODEVICE	(DMA_TO_DEVICE)
> +#define PCI_DMA_FROMDEVICE	(DMA_FROM_DEVICE)
> +#define PCI_DMA_NONE		(DMA_NONE)

No need for the braces.