linux-kernel - Re: [PATCH 2/2] i2c: designware: Add support for a bus clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40f2729f38bd565a829d60d9cc8f508e33b0dc65.camel@linux.intel.com>
Date:   Tue, 17 Jul 2018 17:18:32 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Phil Edworthy <phil.edworthy@...esas.com>,
        Simon Horman <horms@...ge.net.au>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH 2/2] i2c: designware: Add support for a bus clock

On Tue, 2018-07-17 at 12:42 +0000, Phil Edworthy wrote:

> > While your point sounds valid (don't remember how clk_get() is
> > implemented), NULL is also OK to have.
> 
> Ok as in there is no bus clock, right?
> So it should be:
>  if (!IS_ERR_OR_NULL (dev->busclk))

Nope, NULL is no error case for optional clock.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy