[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK8P3a2ZnATY2ZgcV6bDz0bxNhvU3FQCJ5RdNVpanmo5CBy6zw@mail.gmail.com>
Date: Tue, 17 Jul 2018 18:00:50 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Alexander Sverdlin <alexander.sverdlin@...ia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Aleksey Makarov <aleksey.makarov@...ium.com>,
Radoslaw Biernacki <rad@...ihalf.com>,
Felix Manlunas <felix.manlunas@...ium.com>,
Sunil Goutham <sgoutham@...ium.com>,
Vijaya Mohan Guvva <vijaya.guvva@...ium.com>,
Networking <netdev@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: cavium: add missing PCI dependencies
On Tue, Jul 17, 2018 at 4:31 PM, Alexander Sverdlin
<alexander.sverdlin@...ia.com> wrote:
>> @@ -35,7 +35,7 @@ config THUNDER_NIC_BGX
>> tristate "Thunder MAC interface driver (BGX)"
>> depends on 64BIT
>> select PHYLIB
>> - select MDIO_THUNDER
>> + select MDIO_THUNDER if PCI
>> select THUNDER_NIC_RGX
>> ---help---
>> This driver supports programming and controlling of MAC
>
> I believe this hunk should look exactly as the previous one, i.e. 64BIT && PCI,
> BGX itself depends on PCI as well.
That would work as well. My approach was to allow compiling that driver
with PCI because I got no build failures other than the MDIO_THUNDER
issues.
> I've actually sent v2 to fix the above, but got no reply on it up to now...
Your patch was applied into net-next already, so you need to send
a fix relative to your first patch rather than a replacement.
Arnd
Powered by blists - more mailing lists