linux-kernel - [tip:x86/urgent] x86/MCE: Remove min interval polling limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-fbdb328c6bae0a7c78d75734a738b66b86dffc96@git.kernel.org>
Date:   Tue, 17 Jul 2018 09:00:50 -0700
From:   tip-bot for Dewet Thibaut <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     thibaut.dewet@...ia.com, alexander.sverdlin@...ia.com,
        mingo@...nel.org, tony.luck@...el.com, linux-edac@...r.kernel.org,
        bp@...e.de, linux-kernel@...r.kernel.org, hpa@...or.com,
        tglx@...utronix.de
Subject: [tip:x86/urgent] x86/MCE: Remove min interval polling limitation

Commit-ID:  fbdb328c6bae0a7c78d75734a738b66b86dffc96
Gitweb:     https://git.kernel.org/tip/fbdb328c6bae0a7c78d75734a738b66b86dffc96
Author:     Dewet Thibaut <thibaut.dewet@...ia.com>
AuthorDate: Mon, 16 Jul 2018 10:49:27 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Tue, 17 Jul 2018 17:56:25 +0200

x86/MCE: Remove min interval polling limitation

commit b3b7c4795c ("x86/MCE: Serialize sysfs changes") introduced a min
interval limitation when setting the check interval for polled MCEs.
However, the logic is that 0 disables polling for corrected MCEs, see
Documentation/x86/x86_64/machinecheck. The limitation prevents disabling.

Remove this limitation and allow the value 0 to disable polling again.

Fixes: b3b7c4795c ("x86/MCE: Serialize sysfs changes")
Signed-off-by: Dewet Thibaut <thibaut.dewet@...ia.com>
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
[ Massage commit message. ]
Signed-off-by: Borislav Petkov <bp@...e.de>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Tony Luck <tony.luck@...el.com>
Cc: linux-edac <linux-edac@...r.kernel.org>
Cc: stable@...r.kernel.org
Link: http://lkml.kernel.org/r/20180716084927.24869-1-alexander.sverdlin@nokia.com
---
 arch/x86/kernel/cpu/mcheck/mce.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index c102ad51025e..8c50754c09c1 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -2165,9 +2165,6 @@ static ssize_t store_int_with_restart(struct device *s,
 	if (check_interval == old_check_interval)
 		return ret;
 
-	if (check_interval < 1)
-		check_interval = 1;
-
 	mutex_lock(&mce_sysfs_mutex);
 	mce_restart();
 	mutex_unlock(&mce_sysfs_mutex);