linux-kernel - Re: [PATCH] gfs2: remove redundant variable 'moved'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU79qQuWD4o1SFbTshQcmuYAoQvSsNZ49jEWc-oSTthhFw@mail.gmail.com>
Date:   Tue, 17 Jul 2018 18:08:33 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Bob Peterson <rpeterso@...hat.com>,
        cluster-devel <cluster-devel@...hat.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gfs2: remove redundant variable 'moved'

Colin,

On 17 July 2018 at 16:59, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variable 'moved' s being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> warning: variable 'moved' set but not used [-Wunused-but-set-variable]

thanks. I've looked up since when the variable is unused and added
that info. The patch is on for-next now.

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/gfs2/dir.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/gfs2/dir.c b/fs/gfs2/dir.c
> index d97ad89955d1..e37002560c11 100644
> --- a/fs/gfs2/dir.c
> +++ b/fs/gfs2/dir.c
> @@ -1011,7 +1011,7 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
>         u64 bn, leaf_no;
>         __be64 *lp;
>         u32 index;
> -       int x, moved = 0;
> +       int x;
>         int error;
>
>         index = name->hash >> (32 - dip->i_depth);
> @@ -1113,8 +1113,6 @@ static int dir_split_leaf(struct inode *inode, const struct qstr *name)
>
>                         if (!prev)
>                                 prev = dent;
> -
> -                       moved = 1;
>                 } else {
>                         prev = dent;
>                 }
> --
> 2.17.1
>

Andreas