linux-kernel - Re: [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d692a9c4-9d25-0e8e-f2db-756a3ae0a0b0@suse.de>
Date:   Tue, 17 Jul 2018 11:16:06 +0800
From:   Coly Li <colyli@...e.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     linux-bcache@...r.kernel.org, linux-block@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Luis R . Rodriguez" <mcgrof@...e.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>
Subject: Re: [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig

On 2018/7/17 1:48 AM, Randy Dunlap wrote:
> On 07/16/2018 09:55 AM, Coly Li wrote:
>> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> This patch adds crc64 option entry in lib/Kconfig. This patch is part of
>> a patch originally written by Andy Shevchenko, Coly Li cherry-picks it
>> and compose the commit log for a re-written crc64 source code.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Signed-off-by: Coly Li <colyli@...e.de>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Luis R. Rodriguez <mcgrof@...e.com>
>> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Kate Stewart <kstewart@...uxfoundation.org>
>> ---
>>  lib/Kconfig | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/lib/Kconfig b/lib/Kconfig
>> index 706836ec314d..4059df9ec4c7 100644
>> --- a/lib/Kconfig
>> +++ b/lib/Kconfig
>> @@ -170,6 +170,14 @@ config CRC32_BIT
>>  
>>  endchoice
>>  
>> +config CRC64
>> +	tristate "CRC64 functions"
>> +	help
>> +	  This option is provided for the case where no in-kernel-tree
>> +	  modules require CRC64 functions, but a module built outside
>> +	  the kernel tree does. Such modules that use library CRC64
>> +	  functions require M he
> 

Hi Randy,

> eh?  missing something here.
> 

Fix it in v2 series. Thanks.

Coly Li