linux-kernel - Re: [PATCH 3/3] ARM: tegra: tegra20: Fix mixed tabs-spaces indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1531946769.26473.9.camel@toradex.com>
Date:   Wed, 18 Jul 2018 20:46:11 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dev@...xeye.de" <dev@...xeye.de>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
CC:     "pombredanne@...b.com" <pombredanne@...b.com>
Subject: Re: [PATCH 3/3] ARM: tegra: tegra20: Fix mixed tabs-spaces
 indentation

On Wed, 2018-07-18 at 21:48 +0200, Krzysztof Kozlowski wrote:
> Fix indentation and alignment when spaces were used instead of tabs.
> This fixes checkpatch errors like:
> 
>     ERROR: code indent should use tabs where possible
>     #306: FILE: arch/arm/boot/dts/tegra20-paz00.dts:306:
>     +^I^I         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;$
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Acked-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

> ---
>  arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +-
>  arch/arm/boot/dts/tegra20-paz00.dts    | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra20-colibri.dtsi
> b/arch/arm/boot/dts/tegra20-colibri.dtsi
> index e7b9ab09908a..fa1af2dc276c 100644
> --- a/arch/arm/boot/dts/tegra20-colibri.dtsi
> +++ b/arch/arm/boot/dts/tegra20-colibri.dtsi
> @@ -541,7 +541,7 @@
>  
>  	sound {
>  		compatible = "nvidia,tegra-audio-wm9712-
> colibri_t20",
> -			         "nvidia,tegra-audio-wm9712";
> +			     "nvidia,tegra-audio-wm9712";
>  		nvidia,model = "Colibri T20 AC97 Audio";
>  
>  		nvidia,audio-routing =
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> b/arch/arm/boot/dts/tegra20-paz00.dts
> index ef245291924f..7d8aef6ebd3a 100644
> --- a/arch/arm/boot/dts/tegra20-paz00.dts
> +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> @@ -303,7 +303,7 @@
>  		request-gpios = <&gpio TEGRA_GPIO(V, 2)
> GPIO_ACTIVE_HIGH>;
>  		slave-addr = <138>;
>  		clocks = <&tegra_car TEGRA20_CLK_I2C3>,
> -		         <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
> +			 <&tegra_car TEGRA20_CLK_PLL_P_OUT3>;
>  		clock-names = "div-clk", "fast-clk";
>  		resets = <&tegra_car 67>;
>  		reset-names = "i2c";
> @@ -599,8 +599,8 @@
>  			GPIO_ACTIVE_HIGH>;
>  
>  		clocks = <&tegra_car TEGRA20_CLK_PLL_A>,
> -		         <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
> -		         <&tegra_car TEGRA20_CLK_CDEV1>;
> +			 <&tegra_car TEGRA20_CLK_PLL_A_OUT0>,
> +			 <&tegra_car TEGRA20_CLK_CDEV1>;
>  		clock-names = "pll_a", "pll_a_out0", "mclk";
>  	};
>  };

BTW: I am anyway in the process of sending out a major revamp of all our device trees targeting the Tegras and likewise made sure they do pass checkpatch (;-p).