[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ac14e13b-82fb-c623-6dcb-4c944120eb24@infradead.org>
Date: Wed, 18 Jul 2018 14:55:59 -0700
From: Geoff Levand <geoff@...radead.org>
To: Fredrik Noring <noring@...rew.org>, Christoph Hellwig <hch@....de>
Cc: Robin Murphy <robin.murphy@....com>, m.szyprowski@...sung.com,
iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
JuergenUrban@....de
Subject: Re: [PATCH] dma-mapping: Relax warnings for per-device areas
Hi,
On 07/17/2018 09:33 AM, Fredrik Noring wrote:
>>> Here are three other regressions related to the coherent mask WARN_ON_ONCE:
>>
>> They are a pretty strong indication that yes, you should really set
>> the coherent mask if you ever do coherent allocations..
>
> I'm unfortunately unfamiliar with the USB drivers for the PS3. Geoff, what
> do you think about setting a coherent mask?
I guess we need to add a dma_set_coherent_mask() call in the driver
probe routines. I'll send out a patch.
-Geoff
Powered by blists - more mailing lists