linux-kernel - Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro

Open Source and information security mailing list archives

Message-ID: <20180718230705.GD2146@intel.com>
Date:   Wed, 18 Jul 2018 16:07:05 -0700
From:   Rodrigo Vivi <rodrigo.vivi@...el.com>
To:     Lyude Paul <lyude@...hat.com>
Cc:     dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/print: Fix DRM_DEBUG_DP macro

On Wed, Jul 18, 2018 at 05:57:16PM -0400, Lyude Paul wrote:
> This isn't supposed to take dev as an argument, I guess no one noticed!

Apparently no one using it... Why don't we just kill it?

> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>

anyways, if you prefer to keep or have plans to use:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

> ---
>  include/drm/drm_print.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index 767c90b654c5..fc08584a5101 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -310,7 +310,7 @@ void drm_err(const char *format, ...);
>  
>  #define	DRM_DEV_DEBUG_DP(dev, fmt, ...)					\
>  	drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__)
> -#define DRM_DEBUG_DP(dev, fmt, ...)					\
> +#define DRM_DEBUG_DP(fmt, ...)						\
>  	drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)
>  
>  #define _DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...)	\
> -- 
> 2.17.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives