[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180718100309.49c5452a@xps13>
Date: Wed, 18 Jul 2018 10:03:09 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: Wan ZongShun <mcuos.com@...il.com>,
Boris Brezillon <boris.brezillon@...tlin.com>,
Richard Weinberger <richard@....at>,
David Woodhouse <dwmw2@...radead.org>,
Brian Norris <computersforpeace@...il.com>,
Marek Vasut <marek.vasut@...il.com>,
linux-arm-kernel@...ts.infradead.org,
linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nuc900_nand: mark expected switch fall-through
Hi Gustavo,
Prefix should be "mtd: rawnand: nuc900:"
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote on Tue, 10 Jul
2018 08:29:02 -0500:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1471717 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
> drivers/mtd/nand/raw/nuc900_nand.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/nuc900_nand.c b/drivers/mtd/nand/raw/nuc900_nand.c
> index af5b32c9..53a9f6c 100644
> --- a/drivers/mtd/nand/raw/nuc900_nand.c
> +++ b/drivers/mtd/nand/raw/nuc900_nand.c
> @@ -191,8 +191,9 @@ static void nuc900_nand_command_lp(struct mtd_info *mtd, unsigned int command,
> return;
>
> case NAND_CMD_READ0:
> -
> write_cmd_reg(nand, NAND_CMD_READSTART);
> + /* fall through */
Have you checked this is actually the right thing to do?
Thanks,
Miquèl
Powered by blists - more mailing lists