linux-kernel - Re: [PATCH v8 3/4] rtc: ds1307: add offset sysfs for mt41txx chips.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <265d0f74-d1ca-11c3-4157-6c0405ecbcda@micronovasrl.com>
Date:   Wed, 18 Jul 2018 11:36:57 +0200
From:   Giulio Benetti <giulio.benetti@...ronovasrl.com>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        "open list:REAL TIME CLOCK (RTC) SUBSYSTEM" 
        <linux-rtc@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 3/4] rtc: ds1307: add offset sysfs for mt41txx chips.

Il 18/07/2018 11:22, Giulio Benetti ha scritto:
> +#define M41TXX_REG_CONTROL	0x07
> +#	define M41TXX_BIT_OUT		BIT(7)
> +#	define M41TXX_BIT_FT		BIT(6)
> +#	define M41TXX_BIT_CALIB_SIGN	BIT(5)
> +#	define M41TXX_M_CALIBRATION	GENMASK(5, 0)

This must be GENMASK(4, 0) to be 0x1f.
I'm going to send last patchset, sorry everyone for the mess.

Giulio