linux-kernel - Re: [PATCH 2/2] ASoC: AMD: Add an always on fixed 1.8V regulator for da7219 VDDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180718104615.GC5700@sirena.org.uk>
Date:   Wed, 18 Jul 2018 11:46:15 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Daniel Kurtz <djkurtz@...omium.org>
Cc:     Dylan Reid <dgreid@...omium.org>,
        Jimmy Cheng-Yi Chiang <cychiang@...gle.com>,
        Akshu Agrawal <akshu.agrawal@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Alex Deucher <alexander.deucher@....com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: AMD: Add an always on fixed 1.8V regulator for
 da7219 VDDIO

On Tue, Jul 17, 2018 at 06:49:09PM -0600, Daniel Kurtz wrote:
> From: Akshu Agrawal <akshu.agrawal@....com>
> 
> DA7219's VDDIO for our platform need to be configured for 1.8V.
> Hence we register a fixed 1.8V voltage regulator in the machine driver.
> 
> Change-Id: I65fd93e1dd37c3e0d38265b4b1492ea53b93afd4

Again, please don't include noise like this in upstream submissions.

> +++ b/sound/soc/amd/Kconfig
> @@ -8,6 +8,7 @@ config SND_SOC_AMD_CZ_DA7219MX98357_MACH
>  	select SND_SOC_DA7219
>  	select SND_SOC_MAX98357A
>  	select SND_SOC_ADAU7002
> +	select REGULATOR
>  	depends on SND_SOC_AMD_ACP && I2C

This seems inappropriate, I'd expect a dependency and if it were to stay
a select it's also not selecting all the bits required to make this do
something useful.  

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)