linux-kernel - Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPcwjNoZh+sOooCsUECXVAVraMmj2yHfrg22m=3mbQtVnQ@mail.gmail.com>
Date:   Wed, 18 Jul 2018 13:55:26 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anand Moon <linux.amoon@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: exynos5: add missing interrupts for pwm node

On 18 July 2018 at 12:50, Anand Moon <linux.amoon@...il.com> wrote:
> Hi Krzysztof,
>
> On 18 July 2018 at 16:03, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>> On 18 July 2018 at 12:30, Anand Moon <linux.amoon@...il.com> wrote:
>>> Hi
>>>
>>> On 18 July 2018 at 15:27, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>>> On 18 July 2018 at 11:34, Anand Moon <linux.amoon@...il.com> wrote:
>>>>> Add missing GIC interrupts property for pwm nodes.
>>>>>
>>>>> Signed-off-by: Anand Moon <linux.amoon@...il.com>
>>>>> ---
>>>>>  arch/arm/boot/dts/exynos5.dtsi | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
>>>>> index 5d2f0a0..9406108 100644
>>>>> --- a/arch/arm/boot/dts/exynos5.dtsi
>>>>> +++ b/arch/arm/boot/dts/exynos5.dtsi
>>>>> @@ -169,6 +169,11 @@
>>>>>                 pwm: pwm@...d0000 {
>>>>>                         compatible = "samsung,exynos4210-pwm";
>>>>>                         reg = <0x12DD0000 0x100>;
>>>>> +                       interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
>>>>> +                                  <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
>>>>
>>>> Indentation here looks weird - spaces used after tabs but not aligned
>>>> with first entry. Please indent it properly and align it.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> I ram checkpatch before I submit this patch it shown no error.
>>>
>>> # scripts/checkpatch.pl --no-signoff -q
>>> 0001-ARM-dts-exynos5-add-missing-interrupts-for-pwm-node.patch
>>
>> That's good, thank you. Still when I look at it in patchwork the
>> indentation is wrong:
>> https://patchwork.kernel.org/patch/10531753/
>> However it can be patchwork's fault, so are you sure that this is
>> properly indented and aligned?
>>
>> BR,
>> Krzysztof
>
> I prefer vim and I use following plugin
>
> https://github.com/vivien/vim-linux-coding-style
>
> root@...oidxu4:/usr/src/odroidxu4-4kr-devel# wget -nv
> https://patchwork.kernel.org/patch/10531753/mbox/ -O pwm.patch
> 2018-07-18 10:48:09
> URL:https://patchwork.kernel.org/patch/10531753/mbox/ [1460] ->
> "pwm.patch" [1]
> root@...oidxu4:/usr/src/odroidxu4-4kr-devel#
> root@...oidxu4:/usr/src/odroidxu4-4kr-devel# scripts/checkpatch.pl
> --no-signoff -q pwm.patch
> root@...oidxu4:/usr/src/odroidxu4-4kr-devel#
>
> Is their any other way to test checkpatch please let me know.

This is trivial thing and should be fixed after my first reply. But
clearly we need to waste some more time... so I applied the patch to
check whether patchwork shows it properly or not... and it is the
same. Indentation is wrong.

Please fix the weird alignment. You have existing examples in the DTSI
file (rtc node) how to do it. Current indentation is clearly wrong -
why using spaces after tab if this is not aligned properly?

Best regards,
Krzysztof