linux-kernel - Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180718160939.5650559b@bootlin.com>
Date:   Wed, 18 Jul 2018 16:09:39 +0200
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

Hi Gustavo,

On Wed, 18 Jul 2018 08:08:46 -0500
"Gustavo A. R. Silva" <gustavo@...eddedor.com> wrote:

>The use of the | operator always leads to true, which looks rather
>suspect in this case.
>
>Fix this by using & instead.
>

Acked-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Good catch, thanks.

Maxime