linux-kernel - Re: [PATCH] ipv6: ila: select CONFIG_DST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.022530.2143546035904761995.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 02:25:30 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, tom@...bertland.com,
        david.lebrun@...ouvain.be, m.xhonneux@...il.com,
        daniel@...earbox.net, yuvalm@...lanox.com, georg@...mannsweb.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6: ila: select CONFIG_DST_CACHE

From: Arnd Bergmann <arnd@...db.de>
Date: Wed, 18 Jul 2018 10:48:56 +0200

> My randconfig builds came across an old missing dependency for ILA:
> 
> ERROR: "dst_cache_set_ip6" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_get" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_init" [net/ipv6/ila/ila.ko] undefined!
> ERROR: "dst_cache_destroy" [net/ipv6/ila/ila.ko] undefined!
> 
> We almost never run into this by accident because randconfig builds
> end up selecting DST_CACHE from some other tunnel protocol, and this
> one appears to be the only one missing the explicit 'select'.
> 
> From all I can tell, this problem first appeared in linux-4.9
> when dst_cache support got added to ILA.
> 
> Fixes: 79ff2fc31e0f ("ila: Cache a route to translated address")
> Cc: Tom Herbert <tom@...bertland.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.