linux-kernel - Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.025604.450540611611561398.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 02:56:04 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     maxime.chevallier@...tlin.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mvpp2: debugfs: fix incorrect bitwise operator

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Wed, 18 Jul 2018 08:08:46 -0500

> The use of the | operator always leads to true, which looks rather
> suspect in this case.
> 
> Fix this by using & instead.
> 
> Addresses-Coverity-ID: 1471903 ("Wrong operator used")
> Fixes: dba1d918da02 ("net: mvpp2: debugfs: add entries for classifier flows")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied, thanks.