linux-kernel - Re: [PATCH] pktcdvd:checkpatch:fix pointer declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ad3cf3212c434e73375eeb22d2f67fd70702744.camel@wdc.com>
Date:   Wed, 18 Jul 2018 18:06:42 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "raghuhack78@...il.com" <raghuhack78@...il.com>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>
Subject: Re: [PATCH] pktcdvd:checkpatch:fix pointer declaration

On Wed, 2018-07-18 at 21:28 +0530, RAGHU Halharvi wrote:
> * Fix all pointer declaration which causes
>    "ERROR: "foo* bar" should be "foo *bar""

Hello Raghu,

If you would not be aware of this, checkpatch is a tool that is intended to
verify patches before submission and not to verify code that is already
upstream. A detailed explanation of why patches like this one should not be
submitted is available in "A quick guide to why stand-alone checkpatch
patches suck"
(https://lists.kernelnewbies.org/pipermail/kernelnewbies/2014-September/012296.html).

Thanks,

Bart.