linux-kernel - Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQ1cqG+-7sxJjqs86HG3iOdqDWNQZRpTDTev8XYi2jH=BVFOg@mail.gmail.com>
Date:   Wed, 18 Jul 2018 17:51:08 -0700
From:   Andrey Smirnov <andrew.smirnov@...il.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: vf610: Add ZII SSMB SPU3 board

On Wed, Jul 18, 2018 at 3:50 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Andrey,
>
> On Tue, Jul 17, 2018 at 1:06 AM, Andrey Smirnov
> <andrew.smirnov@...il.com> wrote:
>
> > +/dts-v1/;
> > +#include "vf610.dtsi"
> > +
> > +/ {
> > +       model = "ZII VF610 SSMB SPU3 Board";
> > +       compatible = "zii,vf610spu3", "zii,vf610dev", "fsl,vf610";
>
> Looks good to me.
>
> Just a minor comment: Is " "zii,vf610dev" really needed here?
>

It's not used in Linux, but I do rely on it in Barebox here:

https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n94

and here:

https://git.pengutronix.de/cgit/barebox/tree/arch/arm/boards/zii-vf610-dev/board.c#n137

so it's pretty handy to have. I can remove it if it is too much of an eyesore.

Thanks,
Andrey Smirnov