linux-kernel - Re: [PATCH v2 net-next 0/7] Make /sys/class/net per net namespace objects belong to container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Jul 2018 20:07:11 -0500
From:   Tyler Hicks <tyhicks@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     gregkh@...uxfoundation.org, tj@...nel.org,
        stephen@...workplumber.org, dmitry.torokhov@...il.com,
        ebiederm@...ssion.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
        containers@...ts.linux-foundation.org
Subject: Re: [PATCH v2 net-next 0/7] Make /sys/class/net per net namespace
 objects belong to container

On 07/17/2018 11:41 PM, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 18 Jul 2018 13:17:34 +0900 (KST)
> 
>> Ok, I can't let this series rot forever, so I'll apply it to net-next.
> 
> Unfortunately, I had to revert, this breaks the build:
> 
> arch/x86/kernel/cpu/intel_rdt_rdtgroup.c:1506:7: error: too few arguments to function ‘__kernfs_create_file’
>   kn = __kernfs_create_file(parent_kn, name, 0444, 0,
> 

I've got a fix for this. New __kernfs_create_file() users were added
since the v1 of the patch set (defconfig didn't build that code for me).

However, I'm starting to question my assumption that sufficient access
control checks are all in place for the attributes affected by patch #5.
I see a few affected attributes which don't make any capable() calls and
I'm not yet through the entire list.

My current plan is to roll in my build failure fix, drop patch #5,
retest and resubmit as a v3. I wasn't able to get to that today but
should be able to by the end of the week.

Tyler

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)