linux-kernel - Re: [PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to 'iio_xadc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c4ee0db-ac33-b093-4dbb-1742fb029012@xilinx.com>
Date:   Thu, 19 Jul 2018 10:22:07 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Lars-Peter Clausen <lars@...afoo.de>,
        Manish Narani <manish.narani@...inx.com>, <jic23@...nel.org>,
        <knaack.h@....de>, <pmeerw@...erw.net>, <michal.simek@...inx.com>,
        <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <anirudh@...inx.com>, <sgoud@...inx.com>,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 1/4] iio: adc: xilinx: Rename 'channels' variable name to
 'iio_xadc_channels'

On 18.7.2018 13:18, Lars-Peter Clausen wrote:
> On 07/18/2018 01:12 PM, Manish Narani wrote:
>> This patch fix the following checkpatch warning in xadc driver.
>> - Reusing the krealloc arg is almost always a bug.
>>
>> Renamed the 'channels' variable as 'iio_xadc_channels' to fix the above
>> warning.
>>
> 
> This is a bug in checkpatch and should be fixed in checkpatch. The code is
> not actually re-using the parameter. channels and xadc_channels are
> independent variables, just checkpatch somehow does not realize this.

I think it should be fine to have this patch in tree. Change in commit
message to reflect this should be enough. But that's just view.

Thanks,
Michal