linux-kernel - Re: [PATCH] powerpc/prom_init: remove linux,stdout-package property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878t67cu0o.fsf@concordia.ellerman.id.au>
Date:   Thu, 19 Jul 2018 22:03:19 +1000
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Murilo Opsfelder Araujo <muriloo@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        Mathieu Malaterre <malat@...ian.org>,
        Bharata B Rao <bharata@...ux.vnet.ibm.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Alexey Kardashevskiy <aik@...abs.ru>,
        Michael Bringmann <mwb@...ux.vnet.ibm.com>,
        Paul Mackerras <paulus@...ba.org>,
        Cédric Le Goater <clg@...d.org>,
        Nathan Fontenot <nfont@...ux.vnet.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/prom_init: remove linux,stdout-package property

Murilo Opsfelder Araujo <muriloo@...ux.ibm.com> writes:
> On Wed, Jul 18, 2018 at 07:37:37PM +1000, Michael Ellerman wrote:
>> Murilo Opsfelder Araujo <muriloo@...ux.ibm.com> writes:
>> > This property was added in 2004 by
>> >
>> >     https://github.com/mpe/linux-fullhistory/commit/689fe5072fe9a0dec914bfa4fa60aed1e54563e6
>> >
>> > and the only use of it, which was already inside `#if 0`, was removed a month
>> > later by
>> >
>> >     https://github.com/mpe/linux-fullhistory/commit/1fbe5a6d90f6cd4ea610737ef488719d1a875de7
>> >
>> > Fixes: https://github.com/linuxppc/linux/issues/125
>> 
>> That is going to confuse some scripts that are expecting that to be a
>> "Fixes: <some commit>" tag :)
>> 
>> The proper tag to use there would be "Link:".
>> 
>> But, I'd prefer we didn't add github issue links to the history, as I'm
>> not sure they won't bit-rot eventually. Not because I'm a anti-Microsoft
>> conspiracy person but just because it's a repo I set up and manage and
>> there's no long term plan for it necessarily.
>> 
>> > ---
>> >  arch/powerpc/kernel/prom_init.c | 2 --
>> >  1 file changed, 2 deletions(-)
>> 
>> Including the link here would be ideal, as it means it doesn't end up in
>> the commit history, but it does end up in the mail archive. So if we
>> ever really need to find it, it should be there.
>> 
>> cheers
>
> Hi, Michael.
>
> Thanks for reviewing it.  I've sent v2 with your suggestions:
>
>     https://lkml.kernel.org/r/20180718161544.12134-1-muriloo@linux.ibm.com

Thanks.

I had actually already applied the first version, but I didn't say that
in my email did I :}

So I've rebased and applied your v2, thanks.

cheers