linux-kernel - Re: [PATCH v3 0/3] add crc64 calculation as kernel library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 10:45:55 +0800
From:   Coly Li <colyli@...e.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Eric Biggers <ebiggers3@...il.com>,
        Noah Massey <noah.massey@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Hannes Reinecke <hare@...e.de>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
        linux-block@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Lyle <mlyle@...e.org>,
        Kent Overstreet <kent.overstreet@...il.com>,
        Kate Stewart <kstewart@...uxfoundation.org>
Subject: Re: [PATCH v3 0/3] add crc64 calculation as kernel library

On 2018/7/17 10:55 PM, Coly Li wrote:
> This patch set adds basic implementation of crc64 calculation as Linux
> kernel library. Since bcache already does crc64 by itself, this patch
> set also modifies bcache code to use the new crc64 library routine.
> 
> bcache uses crc64 as storage checksum, if a change of crc lib routines
> results an inconsistent result, the unmatched checksum may make bcache
> 'think' the on-disk is corrupted, such change should be avoided or
> detected as early as possible. Therefore the last patch in this series
> adds a crc test framework, to check consistency of different calculations.
> 
> Changelog:
> v3: Remove little endian restriction and remove 'le' from function names.
>     Fixes all review comments of v2
> v2: Combine first two patches into one
>     Fixes all review comments of v1
> v1: Initial version.
> 
> Coly Li


Hi folks,

Many thanks for your review and comments, I do appreciate for your help.
Also thank Andrew to pick up the patches.

Coly Li