linux-kernel - Re: [PATCH v6] x86: Avoid pr_cont() in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180719135605.GG2494@hirez.programming.kicks-ass.net>
Date:   Thu, 19 Jul 2018 15:56:05 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:     mingo@...hat.com, mingo@...nel.org, linux-kernel@...r.kernel.org,
        joe@...ches.com, Rasmus Villemoes <linux@...musvillemoes.dk>,
        Andy Lutomirski <luto@...capital.net>,
        Borislav Petkov <bp@...e.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v6] x86: Avoid pr_cont() in show_opcodes().

On Thu, Jul 19, 2018 at 10:53:03PM +0900, Tetsuo Handa wrote:
> +	if (probe_kernel_read(opcodes, rip - PROLOGUE_SIZE, OPCODE_BUFSIZE))
> +		printk("%sCode: Bad RIP value.\n", loglvl);
> +	else
> +		printk("%sCode: %" __stringify(PROLOGUE_SIZE) "ph <%02x> %"
> +		       __stringify(EPILOGUE_SIZE) "ph\n", loglvl, opcodes,
> +		       opcodes[PROLOGUE_SIZE], opcodes + PROLOGUE_SIZE + 1);
>  }

Kernel coding style wants { } on the else branch because multi-line, and
if we have { } on one leg of an if-else it should also be on the other.